Issue Details (XML | Word | Printable)

Key: DS-131
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Tim Donohue
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DSpace 1.x

Browse By Title displays all titles beginning with punctuation at the top of the list

Created: 30/Mar/09 06:59 PM   Updated: 24/May/10 02:15 PM
Component/s: DSpace API, JSPUI, XMLUI
Affects Version/s: 1.5.0, 1.5.1
Fix Version/s: 1.5.2

Time Tracking:
Not Specified


 Description  « Hide
When browsing by title in either the JSPUI or the XMLUI, titles which contain punctuation appear at the top of the listing.

As an example, the following list provides an example of the title ordering problems currently in DSpace 1.5.1:

"Why is this title first?": It's because it starts with a quote!
...And this is another title starting with punctuation
200: a title starting with a number
This is a title with no punctuation at the beginning
Why is this title last?: It's because it doesn't start with punctuation!

Instead, we should probably ignore punctuation. So, the real order should be this:

200: a title starting with a number
...And this is another title starting with punctuation
This is a title with no punctuation at the beginning
"Why is this title first?": It's because it starts with a quote!
Why is this title last?: It's because it doesn't start with punctuation!

 All   Comments   Work Log   Change History   Subversion Commits   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
Graham Triggs added a comment - 31/Mar/09 06:45 AM
We have two very easy options for this:

1) Add org.dspace.text.filter.StripLeadingNonAlphaNum to the list of TextFilters used in org.dspace.sort.OrderFormatTitle

2) In dspace.cfg, replace org.dspace.sort.OrderFormatTitle with org.dspace.sort.OrderFormatTitleMarc21

The second option provides a more advanced initial article word replacement, that works correctly for many languages. The reason it is not used by default - and why the default ordering does not strip punctuation - is to replicate the behaviour of pre-1.5.x instances.

I'm quite happy to declare the previous behaviour a bug though, and implement one of the options above.

Andrea Bollini added a comment - 31/Mar/09 10:11 AM
I'm agree with Graham, the previous behaviour should be declared a bug...
I like the second approach, use Marc21 as default change..
so we should change the dspace.cfg lines (958-959)

#plugin.named.org.dspace.sort.OrderFormatDelegate= \
# org.dspace.sort.OrderFormatTitle=title
and update the documentation according to this.

The default should be enforced in OrderFormat class

Tim Donohue added a comment - 31/Mar/09 02:33 PM
Graham & Andrea,

I think I like option #2 as well. I'd consider this a bug, so I'd say there's no reason to replicate pre-1.5.x sorting behavior.

Graham, since you know better how this all works, I'll let you take the lead on fixing this for 1.5.2. But, let me know if you won't have the time to do so.